From 328127c55e183e8b09d969e7687328a8ab7f69b8 Mon Sep 17 00:00:00 2001
From: jude <jude@jellywx.com>
Date: Wed, 28 Feb 2024 16:58:44 +0000
Subject: [PATCH] Fix images not setting properly

---
 reminder-dashboard/src/components/Modal/index.tsx  |  8 ++++----
 .../src/components/Reminder/Embed/Author.tsx       |  2 +-
 .../src/components/Reminder/Embed/index.tsx        | 14 ++++++++++++--
 .../src/components/Reminder/ImagePicker.tsx        |  1 +
 4 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/reminder-dashboard/src/components/Modal/index.tsx b/reminder-dashboard/src/components/Modal/index.tsx
index d3e14f9..4aba010 100644
--- a/reminder-dashboard/src/components/Modal/index.tsx
+++ b/reminder-dashboard/src/components/Modal/index.tsx
@@ -1,5 +1,5 @@
-import { JSX } from "preact";
-import { createPortal } from "preact/compat";
+import {JSX} from "preact";
+import {createPortal} from "preact/compat";
 
 type Props = {
     setModalOpen: (open: boolean) => never;
@@ -9,7 +9,7 @@ type Props = {
     children: string | JSX.Element | JSX.Element[] | (() => JSX.Element);
 };
 
-export const Modal = ({ setModalOpen, title, onSubmit, onSubmitText, children }: Props) => {
+export const Modal = ({setModalOpen, title, onSubmit, onSubmitText, children}: Props) => {
     const body = document.querySelector("body");
 
     return createPortal(
@@ -34,7 +34,7 @@ export const Modal = ({ setModalOpen, title, onSubmit, onSubmitText, children }:
                 <section class="modal-card-body">{children}</section>
                 {onSubmit && (
                     <footer class="modal-card-foot">
-                        <button class="button is-success" onInput={onSubmit}>
+                        <button class="button is-success" onClick={onSubmit}>
                             {onSubmitText || "Save"}
                         </button>
                         <button
diff --git a/reminder-dashboard/src/components/Reminder/Embed/Author.tsx b/reminder-dashboard/src/components/Reminder/Embed/Author.tsx
index ad61836..04fc422 100644
--- a/reminder-dashboard/src/components/Reminder/Embed/Author.tsx
+++ b/reminder-dashboard/src/components/Reminder/Embed/Author.tsx
@@ -16,7 +16,7 @@ export const Author = ({ name, icon, setReminder }: Props) => {
                         class="is-rounded embed_author_url"
                         url={icon}
                         alt="Image for embed author"
-                        setImage={(url) => {
+                        setImage={(url: string) => {
                             setReminder((reminder) => ({
                                 ...reminder,
                                 embed_author_url: url,
diff --git a/reminder-dashboard/src/components/Reminder/Embed/index.tsx b/reminder-dashboard/src/components/Reminder/Embed/index.tsx
index 914c3d1..f0ecf81 100644
--- a/reminder-dashboard/src/components/Reminder/Embed/index.tsx
+++ b/reminder-dashboard/src/components/Reminder/Embed/index.tsx
@@ -65,7 +65,12 @@ export const Embed = () => {
                             class="embed_thumbnail_url"
                             url={reminder.embed_thumbnail_url}
                             alt="Square thumbnail embedded image"
-                            setImage={() => {}}
+                            setImage={(url: string) =>
+                                setReminder((reminder: Reminder) => ({
+                                    ...reminder,
+                                    embed_thumbnail_url: url || null,
+                                }))
+                            }
                         />
                     </p>
                 </div>
@@ -76,7 +81,12 @@ export const Embed = () => {
                     class="embed_image_url"
                     url={reminder.embed_image_url}
                     alt="Large embedded image"
-                    setImage={() => {}}
+                    setImage={(url: string) =>
+                        setReminder((reminder: Reminder) => ({
+                            ...reminder,
+                            embed_image_url: url || null,
+                        }))
+                    }
                 />
             </p>
 
diff --git a/reminder-dashboard/src/components/Reminder/ImagePicker.tsx b/reminder-dashboard/src/components/Reminder/ImagePicker.tsx
index a4fd55b..9713962 100644
--- a/reminder-dashboard/src/components/Reminder/ImagePicker.tsx
+++ b/reminder-dashboard/src/components/Reminder/ImagePicker.tsx
@@ -33,6 +33,7 @@ const ImagePickerModal = ({ setModalOpen, setImage }) => {
             title={"Enter Image URL"}
             onSubmit={() => {
                 setImage(value);
+                setModalOpen(false);
             }}
             onSubmitText={"Save"}
         >