Set up logging properly
Rocket's logger was the only one, so messages from the daemons depended on it having launched, and most messages bypassed logging with println!. - Install env_logger at startup: level from log.level (LOG_LEVEL), with RUST_LOG overriding it. Rocket's per-request logs and sqlx's Postgres notices are kept to warnings. - Under systemd, prefix lines with their syslog priority so journald records levels (journalctl -p warning works). - Replace every println! with a log macro at a fitting level. - Recurring failures are a warning when they start or change, debug while they repeat, and an info message when they recover. - Listenbrainz errors are readable: an unknown user is "Listenbrainz user "x" doesn't exist" rather than a JSON decode error, and a period without stats yet (204) leaves the playlist alone instead of failing to decode. The UI's Refresh shows the same messages. - Warnings name the playlist or rule they're about. - Songs missing from the library are debug output, not errors every tick. - Daemons no longer run twice at startup (interval's first tick is immediate), and a failing playlist rule or daemon is logged instead of panicking the task. - Subsonic errors display as messages rather than Debug output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018opPJMJjLWr4RqdG6vuK6p
This commit is contained in:
14 files changed
+436
-67
No files matched your search
@@ -10,7 +10,7 @@ use uuid::Uuid;
|
||||
pub async fn create_playlists_daemon(
|
||||
media_client: impl AsRef<Subsonic> + Clone,
|
||||
) -> Result<(), Box<dyn std::error::Error>> {
|
||||
println!("Create playlist daemon starting...");
|
||||
log::info!("Playlist rule daemon starting");
|
||||
|
||||
let database = PgPool::connect(
|
||||
CONFIG
|
||||
@@ -27,7 +27,11 @@ pub async fn create_playlists_daemon(
|
||||
));
|
||||
ticker.set_missed_tick_behavior(MissedTickBehavior::Skip);
|
||||
|
||||
let mut failures = super::Failures::default();
|
||||
loop {
|
||||
// the first tick completes straight away
|
||||
ticker.tick().await;
|
||||
|
||||
let records_res = sqlx::query_as!(
|
||||
CreateTrackedPlaylist,
|
||||
r#"SELECT * FROM "create_tracked_playlist""#
|
||||
@@ -38,19 +42,19 @@ pub async fn create_playlists_daemon(
|
||||
match records_res {
|
||||
Ok(records) => {
|
||||
for record in records {
|
||||
// todo handle me
|
||||
create_playlist(media_client.clone(), record, database.clone())
|
||||
.await
|
||||
.unwrap();
|
||||
let key = record.id.to_string();
|
||||
let about = format!("playlist rule {:?}", record.name_template);
|
||||
match create_playlist(media_client.clone(), record, database.clone()).await {
|
||||
Ok(()) => failures.succeeded(&key, &about),
|
||||
Err(e) => failures.failed(&key, format!("Could not run {}: {}", about, e)),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Err(e) => {
|
||||
println!("Could not fetch create_tracked_playlist: {:?}", e);
|
||||
log::error!("Could not fetch playlist rules: {}", e);
|
||||
}
|
||||
}
|
||||
|
||||
ticker.tick().await;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -63,6 +67,7 @@ async fn create_playlist(
|
||||
let new_name = now.format(&playlist_rule.name_template).to_string();
|
||||
|
||||
if Some(&new_name) != playlist_rule.last_name.as_ref() {
|
||||
log::info!("Creating playlist {:?}", new_name);
|
||||
// Create playlist
|
||||
let playlist = media_client.as_ref().create_playlist(&new_name).await?;
|
||||
let uuid = Uuid::new_v4();
|
||||
|
||||
Reference in new issue
Block a user