Fix hook

src/commands/command_macro/record.rs

@@ -33,7 +33,11 @@ pub async fn record_macro(
 
     let row = sqlx::query!(
         "
-SELECT 1 as _e FROM macro WHERE guild_id = (SELECT id FROM guilds WHERE guild = ?) AND name = ?",
+        SELECT 1 as _e
+        FROM macro
+        WHERE guild_id = (SELECT id FROM guilds WHERE guild = ?)
+            AND name = ?
+        ",
         guild_id.get(),
         name
     )

src/hooks.rs

@@ -1,3 +1,4 @@
+use log::warn;
 use poise::{serenity_prelude::model::channel::Channel, CreateReply};
 
 use crate::{consts::MACRO_MAX_COMMANDS, models::command_macro::RecordedCommand, Context, Error};
@@ -6,6 +7,9 @@ async fn macro_check(ctx: Context<'_>) -> bool {
     if let Context::Application(app_ctx) = ctx {
         if let Some(guild_id) = ctx.guild_id() {
             if ctx.command().identifying_name != "finish_macro" {
+                let mut lock = ctx.data().recording_macros.write().await;
+
+                if let Some(command_macro) = lock.get_mut(&(guild_id, ctx.author().id)) {
                     if ctx.command().identifying_name != "remind" {
                         let _ = ctx
                         .send(
@@ -18,9 +22,6 @@ async fn macro_check(ctx: Context<'_>) -> bool {
                         return false;
                     }
 
-                let mut lock = ctx.data().recording_macros.write().await;
-
-                if let Some(command_macro) = lock.get_mut(&(guild_id, ctx.author().id)) {
                     if command_macro.commands.len() >= MACRO_MAX_COMMANDS {
                         let _ = ctx
                             .send(
@@ -52,15 +53,9 @@ async fn macro_check(ctx: Context<'_>) -> bool {
 }
 
 async fn check_self_permissions(ctx: Context<'_>) -> bool {
-    if let Some(guild_id) = ctx.guild_id() {
     let user_id = ctx.serenity_context().cache.current_user().id;
 
-        let manage_webhooks = guild_id
+    let (view_channel, send_messages, embed_links, manage_webhooks) = ctx
-            .current_user_member(&ctx)
-            .await
-            .map_or(false, |m| m.permissions(&ctx).map_or(false, |p| p.manage_webhooks()));
-
-        let (view_channel, send_messages, embed_links) = ctx
         .channel_id()
         .to_channel(&ctx)
         .await
@@ -69,14 +64,19 @@ async fn check_self_permissions(ctx: Context<'_>) -> bool {
             if let Channel::Guild(channel) = c {
                 let perms = channel.permissions_for_user(&ctx, user_id).ok()?;
 
-                    Some((perms.view_channel(), perms.send_messages(), perms.embed_links()))
+                Some((
+                    perms.view_channel(),
+                    perms.send_messages(),
+                    perms.embed_links(),
+                    perms.manage_webhooks(),
+                ))
             } else {
                 None
             }
         })
-            .unwrap_or((false, false, false));
+        .unwrap_or((false, false, false, false));
 
-        if manage_webhooks && send_messages && embed_links {
+    if view_channel && manage_webhooks && send_messages && embed_links {
         true
     } else {
         let _ = ctx
@@ -96,9 +96,6 @@ async fn check_self_permissions(ctx: Context<'_>) -> bool {
 
         false
     }
-    } else {
-        true
-    }
 }
 
 pub async fn all_checks(ctx: Context<'_>) -> Result<bool, Error> {

src/main.rs

@@ -49,7 +49,6 @@ type ApplicationContext<'a> = poise::ApplicationContext<'a, Data, Error>;
 
 pub struct Data {
     database: Pool<Database>,
-    http: reqwest::Client,
     recording_macros: RwLock<HashMap<(GuildId, UserId), CommandMacro>>,
     popular_timezones: Vec<Tz>,
     _broadcast: Sender<()>,
@@ -252,7 +251,6 @@ async fn _main(tx: Sender<()>) -> Result<(), Box<dyn StdError + Send + Sync>> {
                 }
 
                 Ok(Data {
-                    http: reqwest::Client::new(),
                     database,
                     popular_timezones,
                     recording_macros: Default::default(),

src/models/command_macro.rs

@@ -1,7 +1,6 @@
 use chrono_tz::Tz;
 use poise::serenity_prelude::model::id::GuildId;
 use serde::{Deserialize, Serialize};
-use serde_json::Value;
 
 use crate::{ApplicationContext, Context};